Skip to content

Add pagination options to list all package versions - #2250

Merged
gmlewis merged 1 commit into
google:masterfrom
lpsm-dev:lucca/add-package-list-opts-user-get-all-versions
Jan 12, 2022
Merged

Add pagination options to list all package versions#2250
gmlewis merged 1 commit into
google:masterfrom
lpsm-dev:lucca/add-package-list-opts-user-get-all-versions

Conversation

@lpsm-dev

@lpsm-devlpsm-dev commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

Here is the detail of the problem: #2251.

@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jan 12, 2022
@codecov

codecovBot commented Jan 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2250 (7da192a) into master (6e66a89) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #2250 +/- ##
=======================================
Coverage 97.80% 97.80% =======================================
Files 113 113 Lines 10207 10211 +4 =======================================
+ Hits 9983 9987 +4 
Misses 156 156 Partials 68 68 
Impacted FilesCoverage Δ
github/users_packages.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e66a89...7da192a. Read the comment docs.

@gmlewisgmlewis changed the title feat: add options to work pagination on list all package versionsAdd pagination options to list all package versionsJan 12, 2022

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lpmatos !
Once you sign the CLA, we can move forward with this PR.
LGTM.

@gmlewis
gmlewis requested a review from wesleimpJanuary 12, 2022 03:46
@gmlewisgmlewis mentioned this pull request Jan 12, 2022
@lpsm-dev

lpsm-dev commented Jan 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Thank you, @lpmatos ! Once you sign the CLA, we can move forward with this PR. LGTM.

@gmlewis Do I have to commit using my gmail? I followed all the steps mentioned in the documentation.

Sorry for the questions, this is my first contribution to a project like this.

@lpsm-dev
lpsm-dev requested a review from gmlewisJanuary 12, 2022 04:15
@gmlewis

Copy link
Copy Markdown
Collaborator

The CLA email needs to match the email address you associated with your GitHub commits, and it looks like you sorted it all out. Thanks.

We are now ready for a second LGTM/Approval from any other contributor to this repo.

Maybe @Parker77 has time to review this some time today.

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @Parker77 !
Merging.

@gmlewis
gmlewis merged commit 002f016 into google:masterJan 12, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lpsm-dev@gmlewis@Parker77