Add list options support for environments by chelnak · Pull Request #2258 · google/go-github

chelnak · 2022-01-17T15:03:59Z

This PR introduces an EnvironmentListOptions parameter for the ListEnvironments method.

Tests have also been updated to reflect the changes and an example has been added to the example directory.

This commit updates existing tests for ListEnvironments to ensure that they will be compatible with the EnvironmentListOptions implementation.

This commit implements EnvironmentListOptions for the ListEnvironments method by adding a new parameter and using the addOptions function. Additionally I've created a new struct called EnvironmentListOptions and embedded ListOptions with the idea that this could be expanded one day.

This commit adds an example to show how to work with ListEnvironments and it's new opts parameter.

gmlewis

Thank you, @chelnak !
Just a few changes are needed for the example... then we will be ready for a second LGTM before merging.

codecov · 2022-01-17T15:31:23Z

Codecov Report

Merging #2258 (ee239cd) into master (2950205) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2258 +/- ##
=======================================
Coverage 97.81% 97.81% =======================================
Files 114 114 Lines 10266 10269 +3 =======================================
+ Hits 10042 10045 +3 
Misses 156 156 Partials 68 68

Impacted Files	Coverage Δ
github/repos_environments.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2950205...ee239cd. Read the comment docs.

Made some minor change to this example that include removing os.Exit(), fixing some unnecessary variable declarations and godoc improvements.

chelnak · 2022-01-17T15:48:51Z

@gmlewis All of your comments should now be resolved. Thanks for taking the time to review.

"unnecessary leading newline (whitespace)"

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

gmlewis

Thank you, @chelnak !
LGTM.
Awaiting second LGTM before merging.

chelnak · 2022-01-24T13:57:09Z

Hello! Is there anything else you would like me to change for this PR?

gmlewis · 2022-01-24T15:46:40Z

Hello! Is there anything else you would like me to change for this PR?

No, thank you. We are awaiting any other contributor to this repo to give an LGTM and approve this PR before merging.

chelnak · 2022-02-02T12:44:16Z

Hey hey! Hope everything is going well! Wondering if we could request a review from another contributor 🙏? Appreciate everyone is super busy though.

gmlewis · 2022-02-03T15:04:10Z

Sorry for the delay, @chelnak !
Hopefully by tomorrow we will be able to get this one merged. Maybe @Parker77 has time to review?

chelnak · 2022-02-03T15:10:48Z

Thank you 🙏 😄

Parker77

LGTM.

gmlewis · 2022-02-03T20:49:34Z

Than you, @Parker77 !
Merging.

fun4cash · 2022-04-07T14:29:23Z

import "github.com/google/go-github/v43/github"

Fixes: google#2257 .

chelnak added 3 commits January 17, 2022 14:59

Tests for EnvironmentListOptions
b07ef07
This commit updates existing tests for ListEnvironments to ensure that they will be compatible with the EnvironmentListOptions implementation.

ListEnvironments example
32b107b
This commit adds an example to show how to work with ListEnvironments and it's new opts parameter.

gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jan 17, 2022

gmlewis requested changes Jan 17, 2022
View reviewed changes

gmlewis requested a review from wesleimp January 17, 2022 15:29

Address PR comments
d92496f
Made some minor change to this example that include removing os.Exit(), fixing some unnecessary variable declarations and godoc improvements.

Resolved a golangci-lint issue
316ee55
"unnecessary leading newline (whitespace)"

gmlewis reviewed Jan 17, 2022
View reviewed changes

Comment threadexample/listenvironments/main.go Outdated

Update example/listenvironments/main.go
ee239cd
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

gmlewis approved these changes Jan 17, 2022
View reviewed changes

Parker77 approved these changes Feb 3, 2022
View reviewed changes

gmlewis merged commit bda32dc into google:masterFeb 3, 2022

gmlewis mentioned this pull request Mar 2, 2022
Bump version of go-github library to v43 #2307
Merged

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Add list options support for environments (google#2258)
b2967cb
Fixes: google#2257 .

Uh oh!

Conversation

chelnak commented Jan 17, 2022

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Jan 17, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chelnak commented Jan 17, 2022

Uh oh!

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

chelnak commented Jan 24, 2022

Uh oh!

gmlewis commented Jan 24, 2022

Uh oh!

chelnak commented Feb 2, 2022

Uh oh!

gmlewis commented Feb 3, 2022

Uh oh!

chelnak commented Feb 3, 2022

Uh oh!

Parker77 left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented Feb 3, 2022

Uh oh!

fun4cash commented Apr 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecovBot commented Jan 17, 2022•
edited
Loading