Skip to content

Update docs for CreateWorkflowDispatchEventRequest.Ref - #2263

Merged
gmlewis merged 1 commit into
google:masterfrom
kylekurz:kkurz/2262-align-documentation
Jan 21, 2022
Merged

Update docs for CreateWorkflowDispatchEventRequest.Ref#2263
gmlewis merged 1 commit into
google:masterfrom
kylekurz:kkurz/2262-align-documentation

Conversation

@kylekurz

Copy link
Copy Markdown
Contributor

go-github documentation on GitHub Actions Workflow parameters indicated
support for branch, tag or SHA, while the official docs indicated only
branch and tag are supported (which was verified by attempting to pass a
SHA to the workflow and seeing it ignored). This small changeset simply
aligns the documentation.

go-github documentation on GitHub Actions Workflow parameters indicated
support for branch, tag or SHA, while the official docs indicated only
branch and tag are supported (which was verified by attempting to pass a
SHA to the workflow and seeing it ignored). This small changeset simply
aligns the documentation.
@kylekurz

Copy link
Copy Markdown
ContributorAuthor

Fixes #2262

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kylekurz !
LGTM.
Merging.

@codecov

codecovBot commented Jan 21, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2263 (b144c9d) into master (178169f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2263 +/- ##
=======================================
Coverage 97.81% 97.81% =======================================
Files 114 114 Lines 10266 10266 =======================================
Hits 10042 10042 Misses 156 156 Partials 68 68 
Impacted FilesCoverage Δ
github/actions_workflows.go100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178169f...b144c9d. Read the comment docs.

@gmlewisgmlewis changed the title 2262 - Documentation MismatchUpdate docs for CreateWorkflowDispatchEventRequest.RefJan 21, 2022
@gmlewis
gmlewis merged commit d4c1caf into google:masterJan 21, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kylekurz@gmlewis