Skip to content

GitHub Actions Billing returns total_paid_minutes_used as float64 - #2284

Merged
gmlewis merged 1 commit into
google:masterfrom
raynigon:master
Feb 9, 2022
Merged

GitHub Actions Billing returns total_paid_minutes_used as float64#2284
gmlewis merged 1 commit into
google:masterfrom
raynigon:master

Conversation

@raynigon

@raynigonraynigon commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

Fixes#2283

GitHub Actions returns total_paid_minutes_used as floating point value.
The Implementation should accept this floating point value as float64.

Example

curl -H "Authorization: Bearer <TOKEN>" \
-H "Accept: application/vnd.github.v3+json" \
https://api.github.com/orgs/{org}/settings/billing/actions
{
"total_minutes_used": 1234,
"total_paid_minutes_used": 3959.0,
"included_minutes": 3000,
"minutes_used_breakdown": {
"UBUNTU": 1234,
"MACOS": 1234,
"WINDOWS": 1234
}
}

GitHub Actions returns total_paid_minutes_used as floating point value.
The Implementation should accept this floating point value as float64.
@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Feb 8, 2022
@codecov

codecovBot commented Feb 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2284 (757e1ce) into master (a842efc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2284 +/- ##
=======================================
Coverage 97.83% 97.83% =======================================
Files 115 115 Lines 10360 10360 =======================================
Hits 10136 10136 Misses 156 156 Partials 68 68 
Impacted FilesCoverage Δ
github/billing.go100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a842efc...757e1ce. Read the comment docs.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @raynigon !
LGTM.

Awaiting second LGTM/Approval from any other contributor to this repo before merging.

@gmlewis

Copy link
Copy Markdown
Collaborator

I'm driving several hundred miles today... I may be slow to respond.

@raynigon

Copy link
Copy Markdown
ContributorAuthor

@Parker77 - do you have time to review this PR?

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @Parker77 !
Merging.

@gmlewis
gmlewis merged commit 2be8000 into google:masterFeb 9, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
GitHub Actions returns total_paid_minutes_used as floating point value.
The Implementation should accept this floating point value as float64.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Actions Billing returns total_paid_minutes_used as float64

3 participants

@raynigon@gmlewis@Parker77