Skip to content

Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitempty - #2289

Merged
gmlewis merged 4 commits into
google:masterfrom
leopoldwang:patch-1
Feb 14, 2022
Merged

Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitempty#2289
gmlewis merged 4 commits into
google:masterfrom
leopoldwang:patch-1

Conversation

@leopoldwang

@leopoldwangleopoldwang commented Feb 11, 2022•
edited by gmlewis
Loading

Copy link
Copy Markdown
Contributor

Fixes: #2286.

gmlewis
gmlewis requested changes Feb 12, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @leopoldwang !
Please run go generate ./... and push (not force-push) the changes to this PR.
See CONTRIBUTING.md for more details.

Comment threadgithub/repos.go
@gmlewisgmlewis changed the title Fix #2286Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitemptyFeb 12, 2022
@codecov

codecovBot commented Feb 12, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2289 (d11e2fd) into master (2be8000) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2289 +/- ##
=======================================
Coverage 97.83% 97.83% =======================================
Files 115 115 Lines 10360 10360 =======================================
Hits 10136 10136 Misses 156 156 Partials 68 68
Impacted FilesCoverage Δ
github/repos.go98.70% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be8000...d11e2fd. Read the comment docs.

gmlewis
gmlewis reviewed Feb 12, 2022
View reviewed changes
Comment threadgithub/repos.go Outdated
gmlewis
gmlewis reviewed Feb 13, 2022
View reviewed changes
Comment threadgithub/repos.go Outdated
gmlewis
gmlewis approved these changes Feb 13, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @leopoldwang !
One tiny nit, but otherwise LGTM.

Awaiting second LGTM/Approval from any other contributor to this repo.

@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Feb 13, 2022
@leopoldwang@gmlewis
Update github/repos.go
d11e2fd
Added missing period.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
gmlewis approved these changes Feb 14, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Awaiting second LGTM/Approval from any other contributor to this repo.

@raynigon

raynigon commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

LGTM.

@gmlewis

gmlewis commented Feb 14, 2022

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merging.

@gmlewis
gmlewis merged commit 6964b1c into google:masterFeb 14, 2022
@gmlewisgmlewis mentioned this pull request Mar 2, 2022
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields w…
f4eda04
…ith omitempty (google#2289)
Fixes: google#2286.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@raynigonraynigonraynigon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RequireCodeOwnerReviews cannot be set to false when updating

3 participants

@leopoldwang@raynigon@gmlewis