Skip to content

Add security-advisory and code-scanning-alert event types - #2311

Merged
gmlewis merged 5 commits into
google:masterfrom
sourikghosh:feat/2306-event-types-uint-test
Mar 4, 2022
Merged

Add security-advisory and code-scanning-alert event types#2311
gmlewis merged 5 commits into
google:masterfrom
sourikghosh:feat/2306-event-types-uint-test

Conversation

@sourikghosh

@sourikghoshsourikghosh commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Sourik Ghosh sourikghosh31@gmail.com

fixes#2306

What does this PR do ?
security-advisory event type with unit test added
code-scanning-alert event type with unit test added

@sourikghosh
security-advisory and code-scanning-alert event types with uint tests…
b7e1025
… added
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
@sourikghosh

sourikghosh commented Mar 3, 2022

Copy link
Copy Markdown
ContributorAuthor

ping reviewer
@gmlewis

@codecov

codecovBot commented Mar 3, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2311 (3b9f271) into master (2a15bc2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2311 +/- ##
=======================================
Coverage 97.84% 97.84% =======================================
Files 115 115 Lines 10403 10415 +12 =======================================
+ Hits 10179 10191 +12 
Misses 156 156 Partials 68 68
Impacted FilesCoverage Δ
github/code-scanning.go100.00% <ø> (ø)
github/event_types.go100.00% <ø> (ø)
github/repos_hooks_deliveries.go92.45% <0.00%> (+2.20%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a15bc2...3b9f271. Read the comment docs.

gmlewis
gmlewis requested changes Mar 3, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sourikghosh !
Just a few minor changes, please, then we will need a second LGTM from any other contributor to this repo before merging.

Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go
Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
@sourikghosh
minor refactoring changes
41aa350
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
@sourikghosh
relevant comments added to newly created structs
f53ab65
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
@sourikghosh
sourikghosh requested a review from gmlewisMarch 3, 2022 15:34
gmlewis
gmlewis requested changes Mar 3, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, @sourikghosh !
Just a couple minor tweaks, please, then we should be ready for another LGTM and merging.

Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
@sourikghosh
struct comment modified
39125f9
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
@sourikghosh
sourikghosh requested a review from gmlewisMarch 3, 2022 17:47
gmlewis
gmlewis approved these changes Mar 3, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sourikghosh !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@sourikghosh

sourikghosh commented Mar 4, 2022

Copy link
Copy Markdown
ContributorAuthor

could any of you please review this PR
@Parker77@JordanSussman@raynigon@contributors

raynigon
raynigon approved these changes Mar 4, 2022
View reviewed changes

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to have the link to the github docs in the comment.
Besides that, LGTM

Comment threadgithub/event_types.go
@gmlewis@raynigon
Update github/event_types.go
3b9f271
Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>
@gmlewis

gmlewis commented Mar 4, 2022

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merging after tests pass.

@gmlewisgmlewis changed the title security-advisory and code-scanning-alert event types with unit test addedAdd security-advisory and code-scanning-alert event typesMar 4, 2022
@gmlewis
gmlewis merged commit 4d609bd into google:masterMar 4, 2022
@gmlewisgmlewis mentioned this pull request Apr 30, 2022
Merged
@emilvaemilva mentioned this pull request Jun 21, 2022
Closed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add security-advisory and code-scanning-alert event types (google#2311)
b2630f4
Fixes: google#2306.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@raynigonraynigonraynigon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add security_advisory and code_scanning_alert event types

3 participants

@sourikghosh@gmlewis@raynigon