Skip to content

Improve stringify test coverage - #2320

Merged
gmlewis merged 2 commits into
google:masterfrom
gmlewis:stringify-tests
Mar 25, 2022
Merged

Improve stringify test coverage#2320
gmlewis merged 2 commits into
google:masterfrom
gmlewis:stringify-tests

Conversation

@gmlewis

Copy link
Copy Markdown
Collaborator

This PR adds missing structs and slices to the stringify tests for better test coverage.

@codecov

codecovBot commented Mar 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2320 (c235e4a) into master (6cd5d41) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head c235e4a differs from pull request most recent head 1bb88f3. Consider uploading reports for the commit 1bb88f3 to get more accurate results

@@ Coverage Diff @@## master #2320 +/- ##
==========================================
+ Coverage 97.87% 97.92% +0.05% 
==========================================
Files 117 115 -2 Lines 10402 10416 +14 ==========================================
+ Hits 10181 10200 +19 + Misses 154 148 -6 - Partials 67 68 +1 
Impacted FilesCoverage Δ
github/repos_contents.go88.95% <0.00%> (-0.38%)⬇️
github/github.go97.64% <0.00%> (-0.10%)⬇️
github/actions_artifacts.go100.00% <0.00%> (ø)
github/actions_workflow_jobs.go100.00% <0.00%> (ø)
github/actions_workflow_runs.go100.00% <0.00%> (ø)
github/repos_actions_permissions.go
github/repos_actions_allowed.go
github/repos.go98.70% <0.00%> (+0.04%)⬆️
github/repos_stats.go95.34% <0.00%> (+2.32%)⬆️
github/misc.go100.00% <0.00%> (+3.63%)⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd5d41...1bb88f3. Read the comment docs.

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

@Parker77 - do you have time for a code review?

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @Parker77 !
Merging.

@gmlewis
gmlewis merged commit 1694b79 into google:masterMar 25, 2022
@gmlewis
gmlewis deleted the stringify-tests branch March 25, 2022 02:43
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gmlewis@Parker77