Skip to content

Remove code duplication - #2321

Merged
gmlewis merged 3 commits into
google:masterfrom
gmlewis:remove-code-duplication
Mar 25, 2022
Merged

Remove code duplication#2321
gmlewis merged 3 commits into
google:masterfrom
gmlewis:remove-code-duplication

Conversation

@gmlewis

@gmlewisgmlewis commented Mar 25, 2022

Copy link
Copy Markdown
Collaborator

This PR removes code duplication as detected by golangci-lint.

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

@Parker77 - do you have time for a code review?

@codecov

codecovBot commented Mar 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2321 (714e01a) into master (631fa70) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2321 +/- ##
==========================================
+ Coverage 97.84% 97.86% +0.01% 
==========================================
Files 115 115 Lines 10416 10352 -64 ==========================================
- Hits 10192 10131 -61 + Misses 156 154 -2 + Partials 68 67 -1 
Impacted FilesCoverage Δ
github/actions_artifacts.go100.00% <100.00%> (ø)
github/actions_workflow_jobs.go100.00% <100.00%> (ø)
github/actions_workflow_runs.go100.00% <100.00%> (ø)
github/github.go97.73% <100.00%> (+0.09%)⬆️
github/repos.go98.66% <100.00%> (-0.05%)⬇️
github/repos_contents.go89.33% <100.00%> (+0.37%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631fa70...714e01a. Read the comment docs.

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @Parker77 !
Merging.

@gmlewis
gmlewis merged commit 6cd5d41 into google:masterMar 25, 2022
@gmlewis
gmlewis deleted the remove-code-duplication branch March 25, 2022 02:33
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gmlewis@Parker77