Skip to content

Make auto-generated files read-only - #2323

Merged
gmlewis merged 1 commit into
google:masterfrom
gmlewis:read-only-auto-gen
Apr 3, 2022
Merged

Make auto-generated files read-only#2323
gmlewis merged 1 commit into
google:masterfrom
gmlewis:read-only-auto-gen

Conversation

@gmlewis

Copy link
Copy Markdown
Collaborator

This PR is to assist new contributors to the repo and hopefully reduce the number of times that people try to edit the auto-generated files.

It makes these files read-only by default and also directs them to run go generate ./... and more importantly, read the instructions in CONTRIBUTING.md.

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Awaiting LGMT+Approval from any other contributor to this repo.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 27, 2022
@codecov

codecovBot commented Mar 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2323 (c28324a) into master (3e8a7f0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2323 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01% 
==========================================
Files 117 117 Lines 10460 10454 -6 ==========================================
- Hits 10256 10250 -6 
Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/event_types.go100.00% <0.00%> (ø)
github/repos_hooks.go100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8a7f0...c28324a. Read the comment docs.

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Merging #2323 (c28324a) into master (3e8a7f0) will decrease coverage by 0.00%.
The diff coverage is n/a.

This report can be ignored.

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @raynigon !
Merging.

@gmlewis
gmlewis merged commit e5684e7 into google:masterApr 3, 2022
@gmlewis
gmlewis deleted the read-only-auto-gen branch April 3, 2022 16:42
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 30, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gmlewis@raynigon