Skip to content

Add support for the pull request review thread event - #2326

Merged
gmlewis merged 1 commit into
google:masterfrom
taisph:feature/gh2324-webhook-event-type-pull_request_review_thread-missing
Apr 3, 2022
Merged

Add support for the pull request review thread event#2326
gmlewis merged 1 commit into
google:masterfrom
taisph:feature/gh2324-webhook-event-type-pull_request_review_thread-missing

Conversation

@taisph

Copy link
Copy Markdown
Contributor

Fixes#2324

Comment threadgithub/pulls_threads.go Outdated
@codecov

codecovBot commented Mar 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2326 (0f34008) into master (c28ccfd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2326 +/- ##
=======================================
Coverage 98.04% 98.04% =======================================
Files 117 118 +1 Lines 10454 10458 +4 =======================================
+ Hits 10250 10254 +4 
Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/event_types.go100.00% <ø> (ø)
github/messages.go100.00% <ø> (ø)
github/event.go100.00% <100.00%> (ø)
github/pulls_threads.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28ccfd...0f34008. Read the comment docs.

@taisph
taisphforce-pushed the feature/gh2324-webhook-event-type-pull_request_review_thread-missing branch from 0a0b536 to 0f34008CompareMarch 30, 2022 21:06
@taisph

Copy link
Copy Markdown
ContributorAuthor

I added the link https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request_review_thread which presumably will be the correct link once they update the docs by looking at the existing structure. I don't know what to expect with regards to when they'll update it as I managed to find a misnamed issue about the missing documentation that was created back in November 2021.

Should this PR be kept back until the docs are updated?

@gmlewis

gmlewis commented Mar 30, 2022

Copy link
Copy Markdown
Collaborator

Should this PR be kept back until the docs are updated?

I don't think that's necessary. Many endpoints have been added in the past just based on observing the response received, so I think this is fine. It can always be updated once the official docs are released. Thank you, @taisph !

@taisph
taisph marked this pull request as ready for review March 30, 2022 21:30
@taisph
taisph requested a review from gmlewisMarch 31, 2022 18:11

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @taisph !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 1, 2022

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merging.

@gmlewis
gmlewis merged commit 1df4afd into google:masterApr 3, 2022
@taisph
taisph deleted the feature/gh2324-webhook-event-type-pull_request_review_thread-missing branch April 4, 2022 07:54
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 30, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhook event type pull_request_review_thread missing

3 participants

@taisph@gmlewis@raynigon