Uh oh!
There was an error while loading. Please reload this page.
Add support to list custom roles for organizations - #2336
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @tamboliasir1 !
Let's please change some of the naming and update the comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
commented
Apr 18, 2022
Please also make sure to run |
tamboliasir1
commented
Apr 24, 2022
Hi @gmlewis I have made changes and pushed commit. Can you please review? Thank you so much. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2336 +/- ##
=======================================
Coverage 98.04% 98.05% =======================================
Files 118 119 +1 Lines 10458 10471 +13 =======================================
+ Hits 10254 10267 +13
Misses 140 140 Partials 64 64
Continue to review full report at Codecov.
|
gmlewis
left a comment
There was a problem hiding this comment.
Sorry, I was wrong.
After you fix the URL in the comments, LGTM.
We will then be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tamboliasir1
commented
Apr 24, 2022
HI @reedloden@gmlewis Sorry for this silly typo I have resolved it please review. Please let me know if there is anything. Thank you. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @tamboliasir1 !
And thank you, @reedloden for catching the typos!
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
joshua-hancox
left a comment
There was a problem hiding this comment.
LGTM (Not a previous contributor though, just an interested party 😄 )
gmlewis
commented
Apr 26, 2022
Thank you, @joshuahancox ! Merging. |
tamboliasir1
commented
Apr 28, 2022
Thank you @gmlewis. Would love to contribute more!!😄 |
reedloden
commented
Apr 28, 2022
@gmlewis can we get a release of |
gmlewis
commented
Apr 28, 2022
I will work on getting a release out before Saturday. |
gmlewis
commented
Apr 30, 2022
@reedloden - https://github.com/google/go-github/releases/tag/v44.0.0 is now available that contains this PR. |
reedloden
commented
Apr 30, 2022
@gmlewis woot woot. Thank you so much! |
Fixes: #2327 .
Thanks for this opportunity.