Skip to content

Add support to list custom roles for organizations - #2336

Merged
gmlewis merged 4 commits into
google:masterfrom
tamboliasir1:issue-2327
Apr 26, 2022
Merged

Add support to list custom roles for organizations#2336
gmlewis merged 4 commits into
google:masterfrom
tamboliasir1:issue-2327

Conversation

@tamboliasir1

@tamboliasir1tamboliasir1 commented Apr 18, 2022

Copy link
Copy Markdown
Contributor

Fixes: #2327 .

Thanks for this opportunity.

@gmlewisgmlewis changed the title Added support to list custom roles for organizationsAdd support to list custom roles for organizationsApr 18, 2022

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tamboliasir1 !
Let's please change some of the naming and update the comments.

Comment threadgithub/org_custom_roles.go
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles_test.go
@gmlewis

Copy link
Copy Markdown
Collaborator

Please also make sure to run go generate ./... and push (not force-push) the results as described in our CONTRIBUTING.md document.

@tamboliasir1

Copy link
Copy Markdown
ContributorAuthor

Hi @gmlewis I have made changes and pushed commit. Can you please review? Thank you so much.

Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go
@codecov

codecovBot commented Apr 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2336 (b01926c) into master (00e4233) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2336 +/- ##
=======================================
Coverage 98.04% 98.05% =======================================
Files 118 119 +1 Lines 10458 10471 +13 =======================================
+ Hits 10254 10267 +13 
Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/org_custom_roles.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e4233...b01926c. Read the comment docs.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was wrong.
After you fix the URL in the comments, LGTM.
We will then be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go

@reedlodenreedloden left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typos. :-)

Comment threadgithub/github-accessors.go Outdated
Comment threadgithub/github-accessors_test.go Outdated
Comment threadgithub/github-accessors_test.go Outdated
Comment threadgithub/github-accessors_test.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles.go Outdated
Comment threadgithub/org_custom_roles_test.go Outdated
@tamboliasir1

Copy link
Copy Markdown
ContributorAuthor

HI @reedloden@gmlewis Sorry for this silly typo I have resolved it please review. Please let me know if there is anything. Thank you.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tamboliasir1 !
And thank you, @reedloden for catching the typos!
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@joshua-hancoxjoshua-hancox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Not a previous contributor though, just an interested party 😄 )

@gmlewis

Copy link
Copy Markdown
Collaborator

LGTM (Not a previous contributor though, just an interested party 😄 )

Thank you, @joshuahancox !

Merging.

@gmlewis
gmlewis merged commit 448e04d into google:masterApr 26, 2022
@tamboliasir1

Copy link
Copy Markdown
ContributorAuthor

Thank you @gmlewis. Would love to contribute more!!😄

@reedloden

Copy link
Copy Markdown

@gmlewis can we get a release of go-github that includes this feature?

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis can we get a release of go-github that includes this feature?

I will work on getting a release out before Saturday.

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis can we get a release of go-github that includes this feature?

@reedloden - https://github.com/google/go-github/releases/tag/v44.0.0 is now available that contains this PR.

@reedloden

Copy link
Copy Markdown

@gmlewis can we get a release of go-github that includes this feature?

@reedloden - https://github.com/google/go-github/releases/tag/v44.0.0 is now available that contains this PR.

@gmlewis woot woot. Thank you so much!

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need a way to list custom roles for organizations

4 participants

@tamboliasir1@gmlewis@reedloden@joshua-hancox