Skip to content

commit with obvious gofmt issue - #2348

Closed
willnorris wants to merge 1 commit into
google:masterfrom
willnorris:gofmt-error
Closed

commit with obvious gofmt issue#2348
willnorris wants to merge 1 commit into
google:masterfrom
willnorris:gofmt-error

Conversation

@willnorris

Copy link
Copy Markdown
Collaborator

No description provided.

@willnorris

Copy link
Copy Markdown
CollaboratorAuthor

@codecov

codecovBot commented Apr 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2348 (2941973) into master (ca149ad) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2348 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 119 119 Lines 10471 10471 =======================================
Hits 10267 10267 Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/github.go97.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca149ad...2941973. Read the comment docs.

@willnorris

Copy link
Copy Markdown
CollaboratorAuthor

This looks to be a problem with golangci-lint, or how we're using it. Running it manually at commit 51df464 (the last in #2333 before the gofmt fix) passes when it shouldn't. I'll keep digging.

@willnorris

Copy link
Copy Markdown
CollaboratorAuthor

Ah, I think I found it.... it's because the example directory is its own go module. I don't think golangci-lint will descent into other modules. cd'ing into the examples directory and then running golangci-lint there correctly identifies the issue. So we'll need to change our actions workflow to manually run on examples and scrape and any other separate modules we have. Gotta run for now, but I can take a look at that later.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@willnorris