Skip to content

run golangci-lint on all modules - #2350

Merged
willnorris merged 3 commits into
google:masterfrom
willnorris:golanglint
Apr 29, 2022
Merged

run golangci-lint on all modules#2350
willnorris merged 3 commits into
google:masterfrom
willnorris:golanglint

Conversation

@willnorris

@willnorriswillnorris commented Apr 29, 2022

Copy link
Copy Markdown
Collaborator

Fixes#2349

@codecov

codecovBot commented Apr 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2350 (88b1675) into master (ca149ad) will not change coverage.
The diff coverage is n/a.

❗ Current head 88b1675 differs from pull request most recent head c6351d6. Consider uploading reports for the commit c6351d6 to get more accurate results

@@ Coverage Diff @@## master #2350 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 119 119 Lines 10471 10471 =======================================
Hits 10267 10267 Misses 140 140 Partials 64 64 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca149ad...c6351d6. Read the comment docs.

@willnorris
willnorrisforce-pushed the golanglint branch 10 times, most recently from 31e094f to 7a6069bCompareApril 29, 2022 17:33
update go.sum for newreposecretwithlibsodium
remove go modules for newreposecretwithxcrypto, since it's unnecessary
@willnorris
willnorris marked this pull request as ready for review April 29, 2022 18:11
@willnorris

Copy link
Copy Markdown
CollaboratorAuthor

I don't love that this now expands out to four linter runs for every PR, but it's the cleanest approach I think and they run super fast.

@willnorris
willnorris requested a review from gmlewisApril 29, 2022 18:12

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @willnorris !
LGTM.

@willnorris
willnorris merged commit c071ded into google:masterApr 29, 2022
@willnorris
willnorris deleted the golanglint branch April 29, 2022 18:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix golangci-lint workflow to run in submodules

2 participants

@willnorris@gmlewis