Skip to content

Add TextMatch custom header to other search type custom headers - #2388

Merged
gmlewis merged 2 commits into
google:masterfrom
DarkMatterV:master
Aug 13, 2022
Merged

Add TextMatch custom header to other search type custom headers#2388
gmlewis merged 2 commits into
google:masterfrom
DarkMatterV:master

Conversation

@DarkMatterV

@DarkMatterVDarkMatterV commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Fix TextMatch Option doesn't work when search type is commits topics repositories or issues (#2385)

Fixes: #2385.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Jun 17, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2388 (398d048) into master (697804f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2388 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 119 119 Lines 10545 10548 +3 =======================================
+ Hits 10341 10344 +3 
Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/search.go93.61% <100.00%> (+0.13%)⬆️
github/repos.go98.66% <0.00%> (+<0.01%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697804f...398d048. Read the comment docs.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DarkMatterV !
Please make sure to run the modified files through gofmt.
See CONTRIBUTING.md for more details.

Comment threadgithub/search.go
@gmlewisgmlewis changed the title Fix TextMatch Option doesn't work when search type is commits topics repositories or issuesAdd TextMatch custom header to other search type custom headersJun 20, 2022

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DarkMatterV !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 20, 2022

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merging.

@gmlewis
gmlewis merged commit 744a645 into google:masterAug 13, 2022
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextMatch doesn't work when use Search.Repositories

3 participants

@DarkMatterV@gmlewis@raynigon