Skip to content

Add MembersCanForkPrivateRepositories field to Organization struct - #2389

Merged
gmlewis merged 2 commits into
google:masterfrom
lmt-swallow:master
Jun 20, 2022
Merged

Add MembersCanForkPrivateRepositories field to Organization struct#2389
gmlewis merged 2 commits into
google:masterfrom
lmt-swallow:master

Conversation

@lmt-swallow

@lmt-swallowlmt-swallow commented Jun 18, 2022

Copy link
Copy Markdown
Contributor

This PR adds MembersCanForkPrivateRepositories field to Organization struct.

Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Jun 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2389 (b510ad5) into master (697804f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2389 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 119 119 Lines 10545 10546 +1 =======================================
+ Hits 10341 10342 +1 
Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/orgs.go96.90% <ø> (ø)
github/repos.go98.66% <0.00%> (+<0.01%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697804f...b510ad5. Read the comment docs.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmt-swallow!
Let's please shorten the field name like it's neighbors.

Comment threadgithub/orgs.go Outdated
…nForkPrivateRepos`
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@lmt-swallow
lmt-swallow requested a review from gmlewisJune 20, 2022 09:54

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmt-swallow !
LGTM.
Merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lmt-swallow@gmlewis