Skip to content

Add support for parsing code_scanning_alerts in webhooks - #2392

Merged
gmlewis merged 1 commit into
google:masterfrom
emilva:code-scanning-alert-event-webhook
Aug 13, 2022
Merged

Add support for parsing code_scanning_alerts in webhooks#2392
gmlewis merged 1 commit into
google:masterfrom
emilva:code-scanning-alert-event-webhook

Conversation

@emilva

@emilvaemilva commented Jun 21, 2022

Copy link
Copy Markdown

Following up on the issue I created #2391.

Let me know if there is anything missing or needs fixing. I just tried to follow the patterns from the other types.

Cheers,

emil

Fixes: #2391.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @emilva !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 21, 2022
@codecov

codecovBot commented Jun 21, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2392 (1f8d04e) into master (8309da1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2392 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 119 119 Lines 10546 10548 +2 =======================================
+ Hits 10342 10344 +2 
Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/messages.go100.00% <ø> (ø)
github/event.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8309da1...1f8d04e. Read the comment docs.

@emilva

Copy link
Copy Markdown
Author

Thanks @gmlewis! :D

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merging.

@gmlewis
gmlewis merged commit 388289c into google:masterAug 13, 2022
@emilva
emilva deleted the code-scanning-alert-event-webhook branch August 15, 2022 16:17
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

code_scanning_alert missing in eventTypeMapping

3 participants

@emilva@gmlewis@raynigon