Skip to content

Add state_reason to IssuesService.Edit - #2395

Merged
gmlewis merged 1 commit into
google:masterfrom
parkr:issues-closed-reason
Jun 24, 2022
Merged

Add state_reason to IssuesService.Edit #2395
gmlewis merged 1 commit into
google:masterfrom
parkr:issues-closed-reason

Conversation

@parkr

Copy link
Copy Markdown
Contributor

state_reason can be 'completed' or 'not_planned'.

I believe we let GitHub document these values, but let me know if you need me to modify this change. Thank you!

Fixes#2393.

/cc @gmlewis

@parkr
parkrforce-pushed the issues-closed-reason branch 2 times, most recently from c7561ea to 016c951CompareJune 23, 2022 05:53
@codecov

codecovBot commented Jun 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2395 (879d435) into master (8309da1) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2395 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 119 119 Lines 10546 10546 =======================================
Hits 10342 10342 Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/issues.go97.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8309da1...879d435. Read the comment docs.

Comment threadgithub/issues.go
state_reason can be 'completed' or 'not_planned'.
@parkr
parkrforce-pushed the issues-closed-reason branch from 016c951 to 879d435CompareJune 24, 2022 02:46

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @parkr !
LGTM.
Merging.

Comment threadgithub/issues.go
@gmlewisgmlewis changed the title IssuesService.Edit: add state_reasonAdd state_reason to IssuesService.Edit Jun 24, 2022
@gmlewis
gmlewis merged commit 404bf94 into google:masterJun 24, 2022
@parkr
parkr deleted the issues-closed-reason branch June 24, 2022 03:45
@parkr

Copy link
Copy Markdown
ContributorAuthor

Thank you so much, @gmlewis!

orestisfl added a commit to orestisfl/i3-github-bot that referenced this pull request Sep 3, 2022
stapelberg pushed a commit to i3/i3-github-bot that referenced this pull request Sep 4, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support state_reason in IssuesService.Edit

2 participants

@parkr@gmlewis