Skip to content

feat: add GetCodeownersErrors to RepositoriesService (#2405) - #2408

Merged
gmlewis merged 6 commits into
google:masterfrom
cbrgm:cbrgm-patch-893ab5
Jul 16, 2022
Merged

feat: add GetCodeownersErrors to RepositoriesService (#2405)#2408
gmlewis merged 6 commits into
google:masterfrom
cbrgm:cbrgm-patch-893ab5

Conversation

@cbrgm

@cbrgmcbrgm commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

This PR adds a new function GetCodeownersErrors to the RepositoriesService struct.
It adds support for the endpoint https://docs.github.com/en/rest/repos/repos#list-codeowners-errors as described in #2405

@codecov

codecovBot commented Jul 8, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2408 (0d5cc3a) into master (fd22ee9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2408 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 119 120 +1 Lines 10546 10558 +12 =======================================
+ Hits 10342 10354 +12 
Misses 140 140 Partials 64 64
Impacted FilesCoverage Δ
github/repos_codeowners.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd22ee9...0d5cc3a. Read the comment docs.

gmlewis
gmlewis requested changes Jul 9, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, @cbrgm - thank you!
Just a few minor tweaks, please, before we have a second reviewer approval.

Comment threadgithub/repos_codeowners.go
Comment threadgithub/repos_codeowners.go Outdated
Comment threadgithub/repos_codeowners.go
Comment threadgithub/repos_codeowners_test.go
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 9, 2022
gmlewis
gmlewis approved these changes Jul 9, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cbrgm !
LGTM.

Awaiting LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 16, 2022
@gmlewis

gmlewis commented Jul 16, 2022

Copy link
Copy Markdown
Collaborator

Thank you, @spikeb4 !
Merging.

@gmlewis
gmlewis merged commit 3a432d6 into google:masterJul 16, 2022
@gmlewisgmlewis mentioned this pull request Aug 19, 2022
Merged
@lachlancooperlachlancooper mentioned this pull request Oct 9, 2023
Closed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add GetCodeownersErrors to RepositoriesService (google#2408)
bf685f6
Fixes: google#2405 .
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@spikeb4spikeb4spikeb4 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbrgm@gmlewis@spikeb4