Uh oh!
There was an error while loading. Please reload this page.
Add 'pending_deployments' endpoint support (#2421) - #2422
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Uh oh!
There was an error while loading. Please reload this page.
DavidGamba
commented
Jul 27, 2022
CLA signed. |
Codecov Report
@@ Coverage Diff @@## master #2422 +/- ##
=======================================
Coverage 98.06% 98.07% =======================================
Files 120 120 Lines 10558 10571 +13 =======================================
+ Hits 10354 10367 +13
Misses 140 140 Partials 64 64
Help us with your feedback. Take ten seconds to tell us how you rate us. |
gmlewis
left a comment
There was a problem hiding this comment.
Just a few minor tweaks, please @DavidGamba.
| type PendingDeploymentsRequest struct { | ||
| EnvironmentIDs []int64 `json:"environment_ids"` | ||
| State *string `json:"state"` | ||
| Comment *string `json:"comment"` |
There was a problem hiding this comment.
Since these two last fields are required, let's please change them to string (instead of *string).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
DavidGamba
commented
Jul 27, 2022
@gmlewis PTAL |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @DavidGamba !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
gmlewis
commented
Aug 13, 2022
Thank you, @raynigon ! |
No description provided.