Skip to content

Add tag protection - #2424

Merged
gmlewis merged 5 commits into
google:masterfrom
jfengupgrade:add-tag-protection
Aug 13, 2022
Merged

Add tag protection#2424
gmlewis merged 5 commits into
google:masterfrom
jfengupgrade:add-tag-protection

Conversation

@jfengupgrade

@jfengupgradejfengupgrade commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecovBot commented Jul 28, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2424 (d7f3036) into master (3a432d6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2424 +/- ##
=======================================
Coverage 98.06% 98.07% =======================================
Files 120 121 +1 Lines 10558 10591 +33 =======================================
+ Hits 10354 10387 +33 
Misses 140 140 Partials 64 64
Impacted FilesCoverage Δ
github/repos_tags.go100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

gmlewis
gmlewis requested changes Jul 28, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jfengupgrade !
Just a few tweaks, please.

Comment threadexample/tagprotection/main.go Outdated
Comment threadexample/tagprotection/main.go Outdated
Comment threadexample/tagprotection/main.go Outdated
Comment threadexample/tagprotection/main.go Outdated
Comment threadexample/tagprotection/main.go Outdated
Comment threadexample/tagprotection/main.go Outdated
Comment threadexample/tagprotection/main.go Outdated
Comment threadgithub/repos_tags.go Outdated
Comment threadgithub/repos_tags.go Outdated
Comment threadgithub/repos_tags.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 28, 2022
gmlewis
gmlewis approved these changes Jul 28, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jfengupgrade !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@jfengupgrade

jfengupgrade commented Jul 28, 2022

Copy link
Copy Markdown
ContributorAuthor

@gmlewis Thanks a lot for the reviewing

raynigon
raynigon approved these changes Aug 13, 2022
View reviewed changes

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

gmlewis commented Aug 13, 2022

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merging.

@gmlewis
gmlewis merged commit aa96e8d into google:masterAug 13, 2022
@jpbelangerupgradejpbelangerupgrade mentioned this pull request Aug 17, 2022
Closed
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
@gmlewisgmlewis mentioned this pull request Aug 19, 2022
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add tag protection (google#2424)
daa3215
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@raynigonraynigonraynigon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfengupgrade@gmlewis@raynigon