Skip to content

Add LFS control - #2429

Merged
gmlewis merged 6 commits into
google:masterfrom
dsm-kb:master
Aug 13, 2022
Merged

Add LFS control#2429
gmlewis merged 6 commits into
google:masterfrom
dsm-kb:master

Conversation

@dsm-kb

Copy link
Copy Markdown
Contributor

Add ability to turn LFS on / off for repo

@google-cla

google-claBot commented Aug 2, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dsm-kbdsm-kb closed this Aug 2, 2022
@dsm-kbdsm-kb reopened this Aug 2, 2022
@dsm-kbdsm-kb closed this Aug 2, 2022
@dsm-kbdsm-kb reopened this Aug 2, 2022
@dsm-kbdsm-kb closed this Aug 2, 2022
@dsm-kbdsm-kb reopened this Aug 2, 2022
@codecov

codecovBot commented Aug 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2429 (df9431b) into master (3a432d6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2429 +/- ##
=======================================
Coverage 98.06% 98.07% =======================================
Files 120 121 +1 Lines 10558 10582 +24 =======================================
+ Hits 10354 10378 +24 
Misses 140 140 Partials 64 64 
Impacted FilesCoverage Δ
github/repos_lfs.go100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dsm-kb
dsm-kb marked this pull request as ready for review August 2, 2022 21:48

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dsm-kb !
Just a few minor tweaks, please, then we should be ready for a second LGTM before merging.

Comment threadgithub/repos_lfs.go Outdated
Comment threadgithub/repos_lfs_test.go Outdated
Comment threadgithub/repos_lfs.go Outdated
Comment threadgithub/repos_lfs.go Outdated
Comment threadgithub/repos_lfs.go Outdated
Comment threadgithub/repos_lfs.go Outdated
Comment threadgithub/repos_lfs_test.go Outdated
Comment threadgithub/repos_lfs_test.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 2, 2022
@dsm-kb
dsm-kb requested a review from gmlewisAugust 3, 2022 01:22

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed a couple minor nits.

Comment threadgithub/repos_lfs.go Outdated
Comment threadgithub/repos_lfs.go Outdated
@dsm-kb
dsm-kb requested a review from gmlewisAugust 3, 2022 01:51

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dsm-kb !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@dsm-kb

Copy link
Copy Markdown
ContributorAuthor

Thank you @gmlewis for the LGTM :-)

@dsm-kbdsm-kb mentioned this pull request Aug 4, 2022

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsm-kb For ypur next PR it would be nice, if you could explain in one or two sentences what you want to do in the PR description. Makes the review a bit easier :)

@gmlewis
gmlewis merged commit 7a7c657 into google:masterAug 13, 2022
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merged.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dsm-kb@gmlewis@raynigon