Skip to content

Add SecretScanningPushProtection field to SecurityAndAnalysis struct - #2476

Merged
gmlewis merged 2 commits into
google:masterfrom
kuhlman-labs:feature/repoadvsecstuct
Sep 22, 2022
Merged

Add SecretScanningPushProtection field to SecurityAndAnalysis struct#2476
gmlewis merged 2 commits into
google:masterfrom
kuhlman-labs:feature/repoadvsecstuct

Conversation

@kuhlman-labs

Copy link
Copy Markdown
Contributor

The Update a repository endpoint in the GitHub API has added an additional field to the security and analysis object to configure secret scanning push protection for a repository. Proposing adding additional fields in SecurityAndAnalysis struct to support configuration with Repositories.Edit
Closes:
#2475

@codecov

codecovBot commented Sep 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2476 (53ca9cd) into master (182338c) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2476 +/- ##
=======================================
Coverage 98.03% 98.03% =======================================
Files 122 122 Lines 10695 10695 =======================================
Hits 10485 10485 Misses 144 144 Partials 66 66 
Impacted FilesCoverage Δ
github/repos.go98.67% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kuhlman-labs !
One minor tweak, please.

Comment threadgithub/repos.go Outdated
@gmlewisgmlewis changed the title Adding SecretScanningPushProtection field to SecurityAndAnalysis struct closes:#2475Add SecretScanningPushProtection field to SecurityAndAnalysis structSep 22, 2022
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kuhlman-labs !
LGTM.
Merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kuhlman-labs@gmlewis