Skip to content

Add support for User SSH signing keys - #2482

Merged
gmlewis merged 1 commit into
google:masterfrom
neersighted:ssh_signing_keys
Oct 12, 2022
Merged

Add support for User SSH signing keys#2482
gmlewis merged 1 commit into
google:masterfrom
neersighted:ssh_signing_keys

Conversation

@neersighted

Copy link
Copy Markdown
Contributor

Introduce support for the new SSH signing key endpoints introduced into the REST API with the introduction of SSH commit verification.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @neersighted !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 28, 2022
@gmlewis

Copy link
Copy Markdown
Collaborator

@neersighted - please use regular push of commits to this PR and not force push, as it makes it really challenging for the reviewer to see what changes each time.

We always use squash and merge in this repo anyway so it doesn't matter how many commits it takes. Thank you.

@codecov

codecovBot commented Sep 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2482 (c3c2c61) into master (0c3cd12) will decrease coverage by 0.04%.
The diff coverage is 89.47%.

@@ Coverage Diff @@## master #2482 +/- ##
==========================================
- Coverage 98.03% 97.99% -0.05% 
==========================================
Files 122 123 +1 Lines 10705 10762 +57 ==========================================
+ Hits 10495 10546 +51 - Misses 144 148 +4 - Partials 66 68 +2 
Impacted FilesCoverage Δ
github/users_ssh_signing_keys.go89.47% <89.47%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neersighted

Copy link
Copy Markdown
ContributorAuthor

Fair -- I'm usually used to a "clean history" workflow -- in this case go generate was missed.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 12, 2022
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewis
gmlewis merged commit 10f65ab into google:masterOct 12, 2022
@neersighted
neersighted deleted the ssh_signing_keys branch October 12, 2022 12:26
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@neersighted@gmlewis@valbeat