Skip to content

Add the 'require_last_push_approval' field - #2567

Merged
gmlewis merged 5 commits into
google:masterfrom
noamd-legit:patch-1
Nov 17, 2022
Merged

Add the 'require_last_push_approval' field #2567
gmlewis merged 5 commits into
google:masterfrom
noamd-legit:patch-1

Conversation

@noamd-legit

Copy link
Copy Markdown
Contributor

No description provided.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis changed the title Consume the 'require_last_push_approval' field from the API responseAdd the 'require_last_push_approval' field Nov 16, 2022

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @noamd-legit !
Could you please also add this field (but as a *bool) to the PullRequestReviewsEnforcementUpdate struct?

@codecov

codecovBot commented Nov 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2567 (8cc248d) into master (cbfb001) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2567 +/- ##
=======================================
Coverage 97.98% 97.98% =======================================
Files 125 125 Lines 10875 10875 =======================================
Hits 10656 10656 Misses 150 150 Partials 69 69 
Impacted FilesCoverage Δ
github/repos.go98.67% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noamd-legit

Copy link
Copy Markdown
ContributorAuthor

@gmlewis Added :)

Comment threadgithub/repos.go Outdated
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis

Copy link
Copy Markdown
Collaborator

You will probably also need to run go generate ./... as described in CONTRIBUTING.md. Sorry for the short reviews... I'm on Android.

@noamd-legit

Copy link
Copy Markdown
ContributorAuthor

go generate doesn't seem to generate diff after syncing with the main branch

@gmlewis

Copy link
Copy Markdown
Collaborator

Did you literally type go generate ./... in the top-level directory?
(Notgo generate.)

@noamd-legit

Copy link
Copy Markdown
ContributorAuthor

Yeah, but apparently I ran the command on a different branch locally 😐
Updated. Sorry for the trouble

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @noamd-legit !
LGTM.
Merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@noamd-legit@gmlewis