Skip to content

Add GetTime method to Timestamp - #2743

Merged
gmlewis merged 2 commits into
google:masterfrom
6543-forks:timestamp_add_gettime
Apr 9, 2023
Merged

Add GetTime method to Timestamp#2743
gmlewis merged 2 commits into
google:masterfrom
6543-forks:timestamp_add_gettime

Conversation

@6543

@65436543 commented Apr 8, 2023

Copy link
Copy Markdown
Contributor

add a small handy helper func

Comment threadgithub/timestamp.go Outdated
@codecov

codecovBot commented Apr 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2743 (8508610) into master (4fec23d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2743 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 132 132 Lines 11611 11616 +5 =======================================
+ Hits 11385 11390 +5 
Misses 154 154 Partials 72 72 
Impacted FilesCoverage Δ
github/timestamp.go100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @6543 .
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 8, 2023
6543 added a commit to 6543-forks/gitea that referenced this pull request Apr 8, 2023
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 9, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @yardenshoham !
Merging.

@gmlewisgmlewis changed the title Add GetTime() to TimestampAdd GetTime method to TimestampApr 9, 2023
@gmlewis
gmlewis merged commit 521fd0d into google:masterApr 9, 2023
@6543
6543 deleted the timestamp_add_gettime branch April 10, 2023 09:27
sonjek pushed a commit to sonjek/gitea that referenced this pull request May 30, 2023
silverwind added a commit to go-gitea/gitea that referenced this pull request May 31, 2023
based on google/go-github#2743
because of
#23946 (comment)
---------
Co-authored-by: silverwind <me@silverwind.io>
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
zeekay pushed a commit to hanzoai/git that referenced this pull request Jul 26, 2026
based on google/go-github#2743
because of
go-gitea#23946 (comment)
---------
Co-authored-by: silverwind <me@silverwind.io>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@6543@gmlewis@yardenshoham