Uh oh!
There was an error while loading. Please reload this page.
Add DNS health checks support for GitHub Pages - #2746
Merged
Conversation
gmlewis
requested changes
Apr 9, 2023
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @oslowalk !
Just a few minor tweaks, please.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2746 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 132 132 Lines 11611 11623 +12 =======================================
+ Hits 11385 11397 +12
Misses 154 154 Partials 72 72
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
approved these changes
Apr 9, 2023
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @oslowalk !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
gmlewis
commented
Apr 12, 2023
Collaborator
Thank you, @valbeat ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#2745
Allows requesting a DNS health check for the CNAME configured for a repository's GitHub Pages.