Skip to content

Update Create/Update methods to return the workflow - #2759

Merged
gmlewis merged 2 commits into
google:masterfrom
avivek:actionRequiredWorkflowpatch
Apr 17, 2023
Merged

Update Create/Update methods to return the workflow#2759
gmlewis merged 2 commits into
google:masterfrom
avivek:actionRequiredWorkflowpatch

Conversation

@avivek

@avivekavivek commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Updated create and update org required workflow methods to return the required workflow object returned by the github api.
Merging this Fixes#2756

@avivekavivek mentioned this pull request Apr 14, 2023
Closed
@codecov

codecovBot commented Apr 14, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2759 (79e6066) into master (6d92e30) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2759 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 132 132 Lines 11628 11638 +10 =======================================
+ Hits 11402 11412 +10 
Misses 154 154 Partials 72 72
Impacted FilesCoverage Δ
github/actions_required_workflows.go100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@avivekavivek mentioned this pull request Apr 14, 2023
Closed
@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Apr 14, 2023
gmlewis
gmlewis requested changes Apr 14, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @avivek !
Just a few minor tweaks, please.
Then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/actions_required_workflows.go
Comment threadgithub/actions_required_workflows.go
Comment threadgithub/actions_required_workflows.go
Comment threadgithub/actions_required_workflows.go
@avivek

avivek commented Apr 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for your quick review @gmlewis .
I have made the changes, please take a look now.

@avivek
avivek requested a review from gmlewisApril 15, 2023 12:40
@gmlewisgmlewis changed the title Updated Create/Update methods to return the workflowUpdate Create/Update methods to return the workflowApr 15, 2023
gmlewis
gmlewis approved these changes Apr 15, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @avivek !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 17, 2023
@gmlewis

gmlewis commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewis
gmlewis merged commit ff89f86 into google:masterApr 17, 2023
@gmlewisgmlewis mentioned this pull request Apr 21, 2023
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Update Create/Update methods to return the workflow (google#2759)
cc84b84
Fixes: google#2756.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@valbeatvalbeatvalbeat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Org Required workflow create and update api's should return the workflow object

3 participants

@avivek@gmlewis@valbeat