Skip to content

Support deployment protection rule event type - #2773

Merged
gmlewis merged 5 commits into
google:masterfrom
BoyangHuang:bo/deployment_protection_rule
May 14, 2023
Merged

Support deployment protection rule event type#2773
gmlewis merged 5 commits into
google:masterfrom
BoyangHuang:bo/deployment_protection_rule

Conversation

@BoyangHuang

@BoyangHuangBoyangHuang commented Apr 27, 2023•
edited by gmlewis
Loading

Copy link
Copy Markdown
Contributor

This commit adds the deployment_protection_rule event type to the list of parseable event types

Fixes: #2774.

@BoyangHuang
Support deployment protection rule event types
f5fd958
This commit adds the deployment_protection_rule event type to the list of parseable event types
@google-cla

google-claBot commented Apr 27, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Apr 27, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2773 (cd5c10f) into master (a938017) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2773 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 132 132 Lines 11638 11640 +2 =======================================
+ Hits 11412 11414 +2 
Misses 154 154 Partials 72 72
Impacted FilesCoverage Δ
github/event_types.go100.00% <ø> (ø)
github/messages.go100.00% <ø> (ø)
github/event.go100.00% <100.00%> (ø)

@BoyangHuangBoyangHuang mentioned this pull request Apr 27, 2023
Closed
gmlewis
gmlewis requested changes Apr 27, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @BoyangHuang !
After a few tweaks, we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/event.go Outdated
Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go
Comment threadgithub/messages.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 27, 2023
@BoyangHuang@gmlewis
Apply suggestions from code review
b19d61e
Thanks for catching all of my misses. Much appreciated :)
I'll run a follow-up `go generate` command after committing your suggestions.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@BoyangHuang

BoyangHuang commented Apr 27, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thank you, @BoyangHuang ! After a few tweaks, we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Thank you @gmlewis for catching my mistakes :) much appreciated

@gmlewis

gmlewis commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

Sorry, I forgot to mention that you will need to gofmt the files after you add my suggestions. Also make sure to run go generate ./... again then push the changes. Thank you!

gmlewis
gmlewis approved these changes Apr 27, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @BoyangHuang !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis changed the title Support deployment protection rule event typesSupport deployment protection rule event typeApr 27, 2023
@BoyangHuang

BoyangHuang commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

small bump here - is there any contributor available to give this a quick look? Thank you!

@gmlewis

gmlewis commented May 8, 2023

Copy link
Copy Markdown
Collaborator

Hi @valbeat - do you have time for a code review?

valbeat
valbeat approved these changes May 14, 2023
View reviewed changes

@valbeatvalbeat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis

gmlewis commented May 14, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label May 14, 2023
@gmlewis
gmlewis merged commit 21df6e0 into google:masterMay 14, 2023
@gmlewisgmlewis mentioned this pull request Jun 6, 2023
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Support deployment protection rule event type (google#2773)
3889bac
Fixes: google#2774.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@valbeatvalbeatvalbeat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Deployment Protection Rule event types

3 participants

@BoyangHuang@gmlewis@valbeat