Skip to content

Add "new_name" parameter to repo transfer request (#2787) - #2788

Merged
gmlewis merged 4 commits into
google:masterfrom
kgalli:master
May 26, 2023
Merged

Add "new_name" parameter to repo transfer request (#2787)#2788
gmlewis merged 4 commits into
google:masterfrom
kgalli:master

Conversation

@kgalli

Copy link
Copy Markdown
Contributor

Resolves: #2787

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kgallikgalli changed the title Add "new_name" prameter to repo transfer request (#2787)Add "new_name" parameter to repo transfer request (#2787)May 26, 2023

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kgalli !
After you make the requested change, please run "go generate ./..." and push (not force-push) the results to this PR, as described in CONTRIBUTING.md.

Comment threadgithub/repos.go Outdated
@codecov

codecovBot commented May 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2788 (fce6b4a) into master (f96b64e) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2788 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 132 132 Lines 11650 11650 =======================================
Hits 11424 11424 Misses 154 154 Partials 72 72 
Impacted FilesCoverage Δ
github/orgs_audit_log.go100.00% <ø> (ø)
github/repos.go98.84% <ø> (ø)

@kgalli

kgalli commented May 26, 2023

Copy link
Copy Markdown
ContributorAuthor

@gmlewis thanks for the hint. I updated the code and run the generate command. Have to admit I haven't thought about the accessors. Very nice that you have generators in place for that.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kgalli !
LGTM.
Merging after tests pass.

@gmlewis
gmlewis merged commit 9e4ce88 into google:masterMay 26, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing parameter "new_name" to repository transfer request

2 participants

@kgalli@gmlewis