Skip to content

Update DependabotSecretsSelectedRepoIDs type to []int64 - #2794

Merged
gmlewis merged 2 commits into
google:masterfrom
jburandt:master
Jun 5, 2023
Merged

Update DependabotSecretsSelectedRepoIDs type to []int64#2794
gmlewis merged 2 commits into
google:masterfrom
jburandt:master

Conversation

@jburandt

Copy link
Copy Markdown
Contributor

According to the docs, the API for setting a repos access to dependabot secrets is expecting an array of integers.

https://docs.github.com/en/rest/dependabot/secrets?apiVersion=2022-11-28#set-selected-repositories-for-an-organization-secret

@google-cla

google-claBot commented Jun 1, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jun 1, 2023
@gmlewisgmlewis changed the title update repo id type to match doc requirementsUpdate repo ID type to match doc requirementsJun 1, 2023
@gmlewisgmlewis changed the title Update repo ID type to match doc requirementsUpdate DependabotSecretsSelectedRepoIDs type to []int64Jun 1, 2023
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 1, 2023

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jburandt !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@codecov

codecovBot commented Jun 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2794 (c800c9f) into master (d6880db) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2794 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 132 132 Lines 11650 11650 =======================================
Hits 11424 11424 Misses 154 154 Partials 72 72 
Impacted FilesCoverage Δ
github/dependabot_secrets.go100.00% <ø> (ø)

@valbeatvalbeat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 5, 2023
@gmlewis
gmlewis merged commit bc019ca into google:masterJun 5, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jburandt@gmlewis@valbeat