Skip to content

Fix missing Include, Exclude fields in RulesetRefConditionParameters - #2810

Merged
gmlewis merged 2 commits into
google:masterfrom
dandehoon:master
Jun 19, 2023
Merged

Fix missing Include, Exclude fields in RulesetRefConditionParameters#2810
gmlewis merged 2 commits into
google:masterfrom
dandehoon:master

Conversation

@dandehoon

Copy link
Copy Markdown
Contributor

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @danztran !
LGTM.
Merging.

@codecov

codecovBot commented Jun 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2810 (640ca68) into master (56c2c3b) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2810 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 136 136 Lines 12263 12263 =======================================
Hits 12025 12025 Misses 162 162 Partials 76 76 
Impacted FilesCoverage Δ
github/repos_rules.go100.00% <ø> (ø)

@gmlewisgmlewis changed the title No omit Include, Exclude fields in RulesetRefConditionParametersFix missing Include, Exclude fields in RulesetRefConditionParametersJun 19, 2023
@gmlewis
gmlewis merged commit 487c80d into google:masterJun 19, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to create Repo Ruleset if RefName fields are empty

2 participants

@dandehoon@gmlewis