Skip to content

Use bytes.Equal instead of bytes.Compare - #2820

Merged
gmlewis merged 1 commit into
google:masterfrom
testwill:bytes
Jun 26, 2023
Merged

Use bytes.Equal instead of bytes.Compare#2820
gmlewis merged 1 commit into
google:masterfrom
testwill:bytes

Conversation

@testwill

Copy link
Copy Markdown
Contributor

should use bytes.Equal(ae.Raw, v.Raw) instead (S1004)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @testwill !
LGTM.
Merging after tests pass.

@codecov

codecovBot commented Jun 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2820 (7b0c945) into master (1e7c685) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2820 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 136 136 Lines 12263 12263 =======================================
Hits 12025 12025 Misses 162 162 Partials 76 76 
Impacted FilesCoverage Δ
github/github.go97.97% <100.00%> (ø)

@gmlewisgmlewis changed the title chore: use bytes.Equal(ae.Raw, v.Raw) insteadUse bytes.Equal instead of bytes.CompareJun 26, 2023
@gmlewis
gmlewis merged commit cd0f4b9 into google:masterJun 26, 2023
@testwill
testwill deleted the bytes branch June 27, 2023 01:25
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@testwill@gmlewis