Skip to content

Add Repository struct to SecretScanningAlert - #2823

Merged
gmlewis merged 1 commit into
google:masterfrom
emilva:add-repo-to-enterprise-secret-scanning-alerts-list
Jun 28, 2023
Merged

Add Repository struct to SecretScanningAlert#2823
gmlewis merged 1 commit into
google:masterfrom
emilva:add-repo-to-enterprise-secret-scanning-alerts-list

Conversation

@emilva

Copy link
Copy Markdown

Add support for getting Repository when listing secret scanning alerts for enterprise

There is no easy way of getting the org/repo when listing secret scanning alerts for enterprise in the current struct. The API returns the Repository field, and with this change it will be included in the SecretScanningAlert struct

…s for Enterprise
There is no easy way of getting the org/repo when listing secret scanning alerts for enterprise in the current struct. The API returns the Repository, and with this change it will be included in the SecretScanningAlert
@codecov

codecovBot commented Jun 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2823 (dc78e50) into master (96726d8) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2823 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 136 136 Lines 12279 12279 =======================================
Hits 12041 12041 Misses 162 162 Partials 76 76 
Impacted FilesCoverage Δ
github/secret_scanning.go100.00% <ø> (ø)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @emilva !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 7a8ab98 into google:masterJun 28, 2023
@emilva
emilva deleted the add-repo-to-enterprise-secret-scanning-alerts-list branch June 28, 2023 21:32
@emilva

Copy link
Copy Markdown
Author

Thank you for the quick merge 🥇

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@emilva@gmlewis