Uh oh!
There was an error while loading. Please reload this page.
Support repository_id in org ruleset conditions - #2825
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@## master #2825 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 136 136 Lines 12279 12279 =======================================
Hits 12041 12041 Misses 162 162 Partials 76 76
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
commented
Jul 4, 2023
Please also update the unit tests so that |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
ysoldak
commented
Jul 4, 2023
🤦 PTAL |
ysoldak
commented
Jul 5, 2023
Thanks, @gmlewis I thought worth to reference GitHub's own statement about API change: The part this PR addresses is "Added a repository picker to target select repositories for organization rulesets." |
gmlewis
commented
Jul 15, 2023
Thank you, @liaodaniel ! |
This PR adds support for referencing repositories by ID in Ruleset conditions.
See https://docs.github.com/en/rest/orgs/rules?apiVersion=2022-11-28#create-an-organization-repository-ruleset
API is changed a bit, probably a low impact since v53.2.0 (with ruleset support added) was released just recently and hopefully not many have code using it in production.
The change
RulesetRepositoryConditionParameters->RulesetRepositoryNamesConditionParametersI'm open for suggestions for a change that would not shake the API.