Skip to content

Implement installation_target webhook event type - #2829

Merged
gmlewis merged 2 commits into
google:masterfrom
RickleAndMortimer:installation_target_event
Jul 19, 2023
Merged

Implement installation_target webhook event type#2829
gmlewis merged 2 commits into
google:masterfrom
RickleAndMortimer:installation_target_event

Conversation

@RickleAndMortimer

@RickleAndMortimerRickleAndMortimer commented Jul 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Implements the installation_target webhook event type.

Description from the API:

This event occurs when there is activity relating to the user or organization account that a GitHub App is installed on

@codecov

codecovBot commented Jul 10, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2829 (b7da72e) into master (9f7124c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2829 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 136 136 Lines 12279 12281 +2 =======================================
+ Hits 12041 12043 +2 
Misses 162 162 Partials 76 76
Impacted FilesCoverage Δ
github/event_types.go100.00% <ø> (ø)
github/messages.go100.00% <ø> (ø)
github/event.go100.00% <100.00%> (ø)

@RickleAndMortimerRickleAndMortimer changed the title Implemented installation_target webhookImplemented installation_target webhook event typeJul 10, 2023
@gmlewisgmlewis changed the title Implemented installation_target webhook event typeImplement installation_target webhook event typeJul 10, 2023
gmlewis
gmlewis requested changes Jul 10, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @RickleAndMortimer !
Just a few tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 10, 2023
gmlewis
gmlewis approved these changes Jul 10, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @RickleAndMortimer !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

raynigon
raynigon approved these changes Jul 19, 2023
View reviewed changes

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 19, 2023
@gmlewis

gmlewis commented Jul 19, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merging.

@gmlewis
gmlewis merged commit 461d387 into google:masterJul 19, 2023
@RickleAndMortimer
RickleAndMortimer deleted the installation_target_event branch July 20, 2023 23:17
@mnafees

mnafees commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

When can we expect a release to be published with this change?

@gmlewis

gmlewis commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

@mnafees - it would be nice to get a couple outstanding PRs merged in before the release since we already have breaking changes. Would you be interested in reviewing these two PRs?

@gmlewisgmlewis mentioned this pull request Aug 16, 2023
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Implement installation_target webhook event type (google#2829)
f9f4894
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@raynigonraynigonraynigon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RickleAndMortimer@gmlewis@mnafees@raynigon