Skip to content

Support line comments on PRs - #2833

Merged
gmlewis merged 2 commits into
google:masterfrom
varmakarthik12:2832
Jul 18, 2023
Merged

Support line comments on PRs#2833
gmlewis merged 2 commits into
google:masterfrom
varmakarthik12:2832

Conversation

@varmakarthik12

@varmakarthik12varmakarthik12 commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis changed the title feat(2832): Implement's line comments on PR'sSupport line comments on PRsJul 18, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

Please run go generate ./... and push (not force-push) the changes to this PR.
See CONTRIBUTING.md for details.

@varmakarthik12

Copy link
Copy Markdown
ContributorAuthor

Please run go generate ./... and push (not force-push) the changes to this PR. See CONTRIBUTING.md for details.

My Bad, This should be good now. LMK.

@codecov

codecovBot commented Jul 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2833 (c23b77d) into master (6c1dedd) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2833 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 137 137 Lines 12289 12289 =======================================
Hits 12051 12051 Misses 162 162 Partials 76 76 
Impacted FilesCoverage Δ
github/pulls_comments.go100.00% <ø> (ø)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @varmakarthik12 !
LGTM.
Merging.

@gmlewis
gmlewis merged commit d783bb1 into google:masterJul 18, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@varmakarthik12@gmlewis