Skip to content

Add secret type display to secret scanning alert - #2834

Merged
gmlewis merged 1 commit into
google:masterfrom
salamachinas:secret-type-display-name
Jul 20, 2023
Merged

Add secret type display to secret scanning alert#2834
gmlewis merged 1 commit into
google:masterfrom
salamachinas:secret-type-display-name

Conversation

@salamachinas

Copy link
Copy Markdown
Contributor

added support for getting secret type display name when listing secret scanning alerts

@codecov

codecovBot commented Jul 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2834 (e675dec) into master (461d387) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2834 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 137 137 Lines 12291 12291 =======================================
Hits 12053 12053 Misses 162 162 Partials 76 76 
Impacted FilesCoverage Δ
github/secret_scanning.go100.00% <ø> (ø)

@gmlewisgmlewis changed the title added secret type display to secret scanning alertAdd secret type display to secret scanning alertJul 20, 2023

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @salamachinas !
LGTM.
Merging.

@gmlewis
gmlewis merged commit b02bb75 into google:masterJul 20, 2023
@salamachinas
salamachinas deleted the secret-type-display-name branch July 20, 2023 12:58
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@salamachinas@gmlewis