Uh oh!
There was an error while loading. Please reload this page.
Add support for SAML SSO authorization APIs - #2835
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joaopenteado !
Just a few tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@## master #2835 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 137 138 +1 Lines 12291 12314 +23 =======================================
+ Hits 12053 12076 +23
Misses 162 162 Partials 76 76
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joaopenteado !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
joaopenteado
commented
Jul 21, 2023
Thank you for the fast review and comments as always, @gmlewis! |
gmlewis
left a comment
There was a problem hiding this comment.
Awesome, @joaopenteado ! Thank you very much!
I was wondering why the coverage dropped, but it looks like you found it and fixed it!
🎉
o-sama
commented
Jul 23, 2023
LGTM too :) |
gmlewis
commented
Jul 24, 2023
Thank you, @o-sama ! |
This PR adds support for both
ListCredentialAuthorizationsandRemoveCredentialAuthorizationmethods available for the GitHub Enterprise Cloud REST API for SAML SSO authorizations.