Skip to content

Fix old_name field in AuditEntry - #2849

Merged
gmlewis merged 7 commits into
google:masterfrom
lmartinking:patch-2
Jul 28, 2023
Merged

Fix old_name field in AuditEntry#2849
gmlewis merged 7 commits into
google:masterfrom
lmartinking:patch-2

Conversation

@lmartinking

Copy link
Copy Markdown
Contributor

Much to my chagrin, the audit log view in the site manager does not follow the shape of the API response.

I previously raised a PR #2843 which was merged yesterday. Unfortunately, it does not work with the payload returned from the API.

My sincere apologies about this.

@codecov

codecovBot commented Jul 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2849 (9f800d2) into master (c8c34d0) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2849 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 138 138 Lines 12318 12318 =======================================
Hits 12080 12080 Misses 162 162 Partials 76 76 
Files ChangedCoverage Δ
github/orgs_audit_log.go100.00% <ø> (ø)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmartinking !
Now worries. I'm glad you caught it before I cut the new release. 😄

Comment threadgithub/orgs_audit_log.go Outdated
Comment threadgithub/orgs_audit_log.go Outdated
@gmlewisgmlewis added Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). NeedsReview PR is awaiting a review before merging. labels Jul 28, 2023
@lmartinking

lmartinking commented Jul 28, 2023

Copy link
Copy Markdown
ContributorAuthor

@gmlewis I have one more field to add, which I will do in another PR

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 28, 2023
lmartinkingand others added 2 commits July 28, 2023 23:13
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@lmartinking

Copy link
Copy Markdown
ContributorAuthor

@gmlewis do you want the structs to mirror the shape of the API or would you prefer it flattened? Which was why I had it as a composite member.

@lmartinking
lmartinking requested a review from gmlewisJuly 28, 2023 14:17
@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis do you want the structs to mirror the shape of the API or would you prefer it flattened? Which was why I had it as a composite member.

We typically do not use composite members in this repo.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmartinking !
LGTM.
Merging.

@gmlewisgmlewis changed the title [Fix] old_name field in AuditEntry is incorrectly mapped from the JSON returned by the Audit Log APIFix old_name field in AuditEntryJul 28, 2023
@gmlewis
gmlewis merged commit 44d09ce into google:masterJul 28, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lmartinking@gmlewis