Uh oh!
There was an error while loading. Please reload this page.
Fix old_name field in AuditEntry - #2849
Conversation
Codecov Report
@@ Coverage Diff @@## master #2849 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 138 138 Lines 12318 12318 =======================================
Hits 12080 12080 Misses 162 162 Partials 76 76
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @lmartinking !
Now worries. I'm glad you caught it before I cut the new release. 😄
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
@gmlewis I have one more field to add, which I will do in another PR |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
lmartinking
commented
Jul 28, 2023
@gmlewis do you want the structs to mirror the shape of the API or would you prefer it flattened? Which was why I had it as a composite member. |
gmlewis
commented
Jul 28, 2023
We typically do not use composite members in this repo. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @lmartinking !
LGTM.
Merging.
old_name field in AuditEntry is incorrectly mapped from the JSON returned by the Audit Log APIold_name field in AuditEntry
Much to my chagrin, the audit log view in the site manager does not follow the shape of the API response.
I previously raised a PR #2843 which was merged yesterday. Unfortunately, it does not work with the payload returned from the API.
My sincere apologies about this.