Skip to content

Add OldLogin field to AuditEntryData - #2850

Merged
gmlewis merged 3 commits into
google:masterfrom
lmartinking:patch-3
Jul 28, 2023
Merged

Add OldLogin field to AuditEntryData#2850
gmlewis merged 3 commits into
google:masterfrom
lmartinking:patch-3

Conversation

@lmartinking

@lmartinkinglmartinking commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

When renaming a Github organisation, the audit log entry (with action org.rename) will contain data.old_login which provides the prior name of the organisation.

This PR builds upon prior work which added support for the data field within an Audit Log entry.

@lmartinking
lmartinking marked this pull request as ready for review July 28, 2023 15:06
@codecov

codecovBot commented Jul 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2850 (61560e8) into master (44d09ce) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2850 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 138 138 Lines 12318 12318 =======================================
Hits 12080 12080 Misses 162 162 Partials 76 76 
Files ChangedCoverage Δ
github/orgs_audit_log.go100.00% <ø> (ø)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmartinking !
LGTM.
Merging.

@gmlewis
gmlewis merged commit f897b2c into google:masterJul 28, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lmartinking@gmlewis