Skip to content

Add ListOptions pagination for Dependabot alerts - #2853

Merged
gmlewis merged 4 commits into
google:masterfrom
jporzucek:master
Aug 8, 2023
Merged

Add ListOptions pagination for Dependabot alerts#2853
gmlewis merged 4 commits into
google:masterfrom
jporzucek:master

Conversation

@jporzucek

@jporzucekjporzucek commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

Fixes2852

@codecov

codecovBot commented Aug 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2853 (3c2420f) into master (f897b2c) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2853 +/- ##
=======================================
Coverage 98.06% 98.06% =======================================
Files 138 138 Lines 12318 12327 +9 =======================================
+ Hits 12080 12089 +9 
Misses 162 162 Partials 76 76 
Files ChangedCoverage Δ
github/dependabot_alerts.go100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@gmlewisgmlewis added Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). waiting for reply labels Aug 1, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

Please see feedback here: #2852 (comment)

@jporzucekjporzucek changed the title Switch to ListOptions pagination for Dependabot alertsAdd ListOptions pagination for Dependabot alertsAug 8, 2023
@gmlewisgmlewis removed waiting for reply Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Aug 8, 2023

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 899235e into google:masterAug 8, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List Dependabot alerts endpoint stopped supporting cursor pagination

2 participants

@jporzucek@gmlewis