Skip to content

Add support for Dependency Graph Snapshots endpoint - #2856

Merged
gmlewis merged 7 commits into
google:masterfrom
be0x74a:dependecy_graph_snapshots
May 5, 2024
Merged

Add support for Dependency Graph Snapshots endpoint#2856
gmlewis merged 7 commits into
google:masterfrom
be0x74a:dependecy_graph_snapshots

Conversation

@be0x74a

Copy link
Copy Markdown
Contributor

Starts Dependency Graph service support by starting with the Create Snapshot endpoint

Comment threadREADME.md Outdated
Comment threadgithub/github.go Outdated
Comment threadgithub/dependency_graph_snapshots.go Outdated
@codecov

codecovBot commented Aug 7, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (2b8c7fa) to head (fb0a8ef).
Report is 45 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #2856 +/- ##
==========================================
- Coverage 97.72% 92.89% -4.84% 
==========================================
Files 153 171 +18 Lines 13390 11436 -1954 ==========================================
- Hits 13085 10623 -2462 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@be0x74a
be0x74a requested a review from gmlewisAugust 19, 2023 14:09

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a !

Comment threadgithub/dependency_graph_snapshots.go Outdated
Comment threadgithub/dependency_graph_snapshots.go
@gmlewis

Copy link
Copy Markdown
Collaborator

@be0x74a - we'll leave this PR open for a week or two, but if we haven't heard back from you, we will close this PR as abandoned.

@be0x74a
be0x74aforce-pushed the dependecy_graph_snapshots branch from 3ede035 to ef18b6cCompareApril 28, 2024 22:30
@be0x74a
be0x74a requested a review from gmlewisApril 28, 2024 22:37
@be0x74a

Copy link
Copy Markdown
ContributorAuthor

@be0x74a - we'll leave this PR open for a week or two, but if we haven't heard back from you, we will close this PR as abandoned.

@gmlewis finally got to it! Sorry for the delay and the force-push, was trying to appease codecov and make it use a recent base but I completely failed...

@googlegoogle deleted a comment from Al8900Apr 29, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a !
This looks much better. Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/dependency_graph_snapshots.go Outdated
Comment threadgithub/dependency_graph_snapshots.go Outdated
Comment threadgithub/dependency_graph_snapshots.go Outdated
be0x74aand others added 2 commits April 29, 2024 22:03
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@be0x74a

Copy link
Copy Markdown
ContributorAuthor

Thanks for the input @gmlewis!

@be0x74a
be0x74a requested a review from gmlewisApril 29, 2024 21:09

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. and removed waiting for reply labels Apr 29, 2024

@tomfeigintomfeigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label May 5, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @tomfeigin !
Merging.

@gmlewis
gmlewis merged commit 807d5cf into google:masterMay 5, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@be0x74a@gmlewis@tomfeigin@Al8900