Skip to content

Add support for Security Advisories Request CVE endpoint - #2857

Merged
gmlewis merged 5 commits into
google:masterfrom
be0x74a:security_advisories_cve
Aug 13, 2023
Merged

Add support for Security Advisories Request CVE endpoint#2857
gmlewis merged 5 commits into
google:masterfrom
be0x74a:security_advisories_cve

Conversation

@be0x74a

@be0x74abe0x74a commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

Fixes#2855

gmlewis
gmlewis requested changes Aug 7, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a

Comment threadREADME.md Outdated
Comment threadgithub/github.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories_test.go
@codecov

codecovBot commented Aug 7, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2857 (2353a17) into master (b989bf4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2857 +/- ##
=======================================
Coverage 98.06% 98.07% =======================================
Files 138 139 +1 Lines 12327 12342 +15 =======================================
+ Hits 12089 12104 +15 
Misses 162 162 Partials 76 76
Files ChangedCoverage Δ
github/github.go97.97% <100.00%> (+<0.01%)⬆️
github/security_advisories.go100.00% <100.00%> (ø)

@be0x74a
be0x74a requested a review from gmlewisAugust 8, 2023 08:15
gmlewis
gmlewis reviewed Aug 8, 2023
View reviewed changes
Comment threadgithub/security_advisories.go Outdated
@be0x74a
be0x74a requested a review from gmlewisAugust 8, 2023 12:05
gmlewis
gmlewis approved these changes Aug 8, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 8, 2023
@be0x74a

be0x74a commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you for the time you took to review and feedback on the PR @gmlewis

vandanrohatgi
vandanrohatgi approved these changes Aug 13, 2023
View reviewed changes

@vandanrohatgivandanrohatgi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis

gmlewis commented Aug 13, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @vandanrohatgi !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 13, 2023
@gmlewis
gmlewis merged commit f36dfa5 into google:masterAug 13, 2023
@gmlewisgmlewis mentioned this pull request Aug 16, 2023
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add support for Security Advisories Request CVE endpoint (google#2857)
3dd1ee4
Fixes: google#2855.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@vandanrohatgivandanrohatgivandanrohatgi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support new API to Request a CVE for a repository security advisory

3 participants

@be0x74a@gmlewis@vandanrohatgi