Skip to content

Add support for the security and analysis webhook event - #2862

Merged
gmlewis merged 4 commits into
google:masterfrom
byronwolfman:add-security-and-analysis-event
Aug 14, 2023
Merged

Add support for the security and analysis webhook event#2862
gmlewis merged 4 commits into
google:masterfrom
byronwolfman:add-security-and-analysis-event

Conversation

@byronwolfman

@byronwolfmanbyronwolfman commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Fixes#2861

Adds support for the Security and Analysis webhook event which fires whenever security and analysis features are enabled or disabled for a repository.

  • Ran go generate
  • Ran go test
  • Ran go vet
  • Signed CLA

@google-cla

google-claBot commented Aug 8, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @byronwolfman !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 8, 2023
@codecov

codecovBot commented Aug 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2862 (445fe2a) into master (f36dfa5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2862 +/- ##
=======================================
Coverage 98.07% 98.07% =======================================
Files 139 139 Lines 12342 12344 +2 =======================================
+ Hits 12104 12106 +2 
Misses 162 162 Partials 76 76 
Files ChangedCoverage Δ
github/event_types.go100.00% <ø> (ø)
github/messages.go100.00% <ø> (ø)
github/event.go100.00% <100.00%> (ø)

@byronwolfman

Copy link
Copy Markdown
ContributorAuthor

Thank you, @byronwolfman ! LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Thanks, sounds good! And thanks for the clear contributing docs that made it possible to put this together. 🙏 💯

@gmlewis

Copy link
Copy Markdown
Collaborator

Thanks, sounds good! And thanks for the clear contributing docs that made it possible to put this together. 🙏 💯

Thank YOU for reading it! It would be nice if every PR author read it!!! 😂

@byronwolfman

Copy link
Copy Markdown
ContributorAuthor

Good morning! What sort of timeline should we expect for merging, and/or what trees do we need to shake? :D

@gmlewis

Copy link
Copy Markdown
Collaborator

This repo is maintained by volunteers and for this PR we need another contributor to this repo to perform a second code review before this will be merged.

Feel free to request code reviews from other contributors to this repo to move the process along. Thanks.

@byronwolfman

Copy link
Copy Markdown
ContributorAuthor

Gently tagging @jporzucek for review as I see you've done some recent work on security and analysis APIs. 🙏

@jporzucek

Copy link
Copy Markdown
Contributor

LGTM! 🚀

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @jporzucek !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 14, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

cc: @evankanderson - this will also affect #2865. Sorry about that.

@gmlewis
gmlewis merged commit 5ac6057 into google:masterAug 14, 2023
@byronwolfman
byronwolfman deleted the add-security-and-analysis-event branch August 14, 2023 15:00
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: support Security and Analysis webhook event

3 participants

@byronwolfman@gmlewis@jporzucek