Skip to content

Add TriggeringActor to WorkflowRun - #2879

Merged
gmlewis merged 3 commits into
google:masterfrom
gmlewis:chore/i2874-add-triggering-actor
Aug 16, 2023
Merged

Add TriggeringActor to WorkflowRun#2879
gmlewis merged 3 commits into
google:masterfrom
gmlewis:chore/i2874-add-triggering-actor

Conversation

@gmlewis

@gmlewisgmlewis commented Aug 16, 2023

Copy link
Copy Markdown
Collaborator

Fixes: #2874 .

This PR also improves the developer experience by making the output of testJSONMarshal more readable.
This PR also runs "go mod tidy" which appears to be long overdue.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

@Parker77 - do you have time for a review, please?

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov

codecovBot commented Aug 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2879 (677e79d) into master (2831a6b) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2879 +/- ##
=======================================
Coverage 98.07% 98.07% =======================================
Files 139 139 Lines 12357 12357 =======================================
Hits 12119 12119 Misses 162 162 Partials 76 76 
Files ChangedCoverage Δ
github/actions_workflow_runs.go100.00% <ø> (ø)

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @Parker77!
Merging.

@gmlewis
gmlewis merged commit b9027bd into google:masterAug 16, 2023
@gmlewis
gmlewis deleted the chore/i2874-add-triggering-actor branch August 16, 2023 16:50
gmlewis added a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance WorkflowRun struct with TriggeringActor

2 participants

@gmlewis@Parker77