Skip to content

Add support for organization, repository webhook configuration - #2885

Merged
gmlewis merged 3 commits into
google:masterfrom
mnafees:webhook-config
Aug 21, 2023
Merged

Add support for organization, repository webhook configuration#2885
gmlewis merged 3 commits into
google:masterfrom
mnafees:webhook-config

Conversation

@mnafees

@mnafeesmnafees commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Closes#2884

This PR adds support for fetching and updating organization, repository webhook configuration

  • go generate
  • go test
  • go vet

@codecov

codecovBot commented Aug 19, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2885 (7aa8ad8) into master (7ceef94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2885 +/- ##
=======================================
Coverage 98.06% 98.07% =======================================
Files 140 142 +2 Lines 12293 12341 +48 =======================================
+ Hits 12055 12103 +48 
Misses 162 162 Partials 76 76
Files ChangedCoverage Δ
github/orgs_hooks_configuration.go100.00% <100.00%> (ø)
github/repos_hooks_configuration.go100.00% <100.00%> (ø)

gmlewis
gmlewis requested changes Aug 19, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mnafees !
Just a couple tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/orgs_hooks_configuration.go Outdated
Comment threadgithub/orgs_hooks_configuration.go Outdated
Comment threadgithub/repos_hooks_configuration.go Outdated
Comment threadgithub/repos_hooks_configuration.go Outdated
@mnafees
mnafees requested a review from gmlewisAugust 20, 2023 08:41
gmlewis
gmlewis approved these changes Aug 20, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mnafees !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 20, 2023
@gmlewis

gmlewis commented Aug 21, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @gabriel-samfira !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 21, 2023
@gmlewis
gmlewis merged commit 505b7ea into google:masterAug 21, 2023
@gmlewisgmlewis mentioned this pull request Sep 5, 2023
Merged
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
@mnafees@gmlewis
Add support for organization, repository webhook configuration (googl…
224f6c8
…e#2885)
Fixes: google#2884.
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add support for organization, repository webhook configuration (googl…
1a3bc94
…e#2885)
Fixes: google#2884.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@gabriel-samfiragabriel-samfiragabriel-samfira approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for organization, repository webhook configuration

3 participants

@mnafees@gmlewis@gabriel-samfira