Skip to content

Add GenerateEnterpriseJITConfig - #2890

Merged
gmlewis merged 2 commits into
google:masterfrom
gabriel-samfira:add-enterprise-jitconfig
Sep 6, 2023
Merged

Add GenerateEnterpriseJITConfig#2890
gmlewis merged 2 commits into
google:masterfrom
gabriel-samfira:add-enterprise-jitconfig

Conversation

@gabriel-samfira

@gabriel-samfiragabriel-samfira commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

With version 3.10 of GitHub Enterprise server, the new just-in-time runner configuration is available for enterprises.

See: https://docs.github.com/en/enterprise-cloud@latest/rest/actions/self-hosted-runners?apiVersion=2022-11-28#create-configuration-for-a-just-in-time-runner-for-an-enterprise

CC: @mkulke

With version 3.10 of GitHub Enterprise server, the new just-in-time runner
configuration is available for enterprises.
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
@codecov

codecovBot commented Aug 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2890 (4b55d56) into master (b700431) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 4b55d56 differs from pull request most recent head c04bf94. Consider uploading reports for the commit c04bf94 to get more accurate results

@@ Coverage Diff @@## master #2890 +/- ##
==========================================
- Coverage 98.12% 98.06% -0.06% 
==========================================
Files 142 140 -2 Lines 12453 12306 -147 ==========================================
- Hits 12219 12068 -151 - Misses 159 162 +3 - Partials 75 76 +1 
Files ChangedCoverage Δ
github/enterprise_actions_runners.go100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gabriel-samfira !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 6, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

@WillAbides - do you have time for a code review on this one?
I apparently forgot to add the "NeedsReview" label on it a couple weeks ago - sorry about that, @gabriel-samfira !

@gabriel-samfira

Copy link
Copy Markdown
ContributorAuthor

No worries at all @gmlewis !

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 6, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @WillAbides !
Merging.

@gmlewis
gmlewis merged commit 66b1147 into google:masterSep 6, 2023
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gabriel-samfira@gmlewis@WillAbides