Uh oh!
There was an error while loading. Please reload this page.
Add enterprise runner group operations - #2891
Conversation
This change adds runner group operations on enterprises. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Codecov Report
@@ Coverage Diff @@## master #2891 +/- ##
==========================================
+ Coverage 98.12% 98.14% +0.02%
==========================================
Files 142 143 +1 Lines 12453 12593 +140 ==========================================
+ Hits 12219 12359 +140
Misses 159 159 Partials 75 75
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gabriel-samfira for the very clean and well-written PR!
❤️
Just one tiny nit, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gabriel-samfira !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
commented
Aug 21, 2023
I had forgotten about the |
WillAbides
commented
Aug 30, 2023
For consistency with ActionsService, should the "*RunnerGroup" methods be renamed to "*EnterpriseRunnerGroup"? This PR also takes the opposite approach with the "*GroupRunners" methods. ActionsService doesn't include "Organization" in those method names, but EnterpriseService includes "Enterprise". I think the ActionsService names make more sense because they are acting on a "Runner", not an "OrganizationRunner" or "EnterpriseRunner". |
gmlewis
commented
Aug 30, 2023
Excellent points, @WillAbides - I think you are right. |
gabriel-samfira
commented
Sep 5, 2023
Ohh wow. For some reason I did not get a notification for your comments. I will make these changes ASAP. Thanks for the review! |
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
commented
Sep 6, 2023
Hopefully I got all the names right. Let me know if I missed (or misunderstood) anything. |
gmlewis
commented
Sep 6, 2023
Thank you, @WillAbides ! |
ajschmidt8
commented
Sep 6, 2023
Appreciate the work here! My team will benefit from these changes as well. Thanks, everyone. |
This change adds runner group operations on enterprises. The operations are essentially a mirror of the org runner group code, adapted for enterprises.