Uh oh!
There was an error while loading. Please reload this page.
Return json.Unmarshal error when importing issues deferred - #2892
Conversation
Codecov Report
@@ Coverage Diff @@## master #2892 +/- ##
==========================================
+ Coverage 98.06% 98.10% +0.04%
==========================================
Files 140 142 +2 Lines 12269 12340 +71 ==========================================
+ Hits 12031 12106 +75 + Misses 162 159 -3 + Partials 76 75 -1
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @nikpivkin !
Could you please add a test case that demonstrates the problem?
In the past, I've found it really handy to demonstrate json.Unmarshal errors by forcing the data to be something bogus for JSON like {].
nikpivkin
commented
Aug 21, 2023
@gmlewis Hi! Fixed! The initial fix was that the error did not return when the response status was 202. (nil returned) |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @nikpivkin !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
gmlewis
commented
Aug 22, 2023
Thank you, @gabriel-samfira ! |
The error was not returned when the 202 status was received during the issues import.