Add Repository Security Advisories APIs

[anishrajan25]

Relates to #2866

Integrates the following 2 APIs:

• Lists repository security advisories for an organization - /orgs/{org}/security-advisories
• Lists security advisories in a repository - /repos/{owner}/{repo}/security-advisories

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[anishrajan25]

@gmlewis The PR is ready for review. Could you please have a look as per your availability?

[gmlewis]

I don't have time for a full review right now, but at a quick glance, it looks like you are defining a whole bunch of new structs... possibly more than necessary. We try to reuse structs when the meaning is similar if possible.

It also looks like you are redefining ListOptions and/or ListCursorOptions when they could be embedded into other options... please look around this repo for examples on how to do this.

Third, all new structs must have complete sentences ending in a period for the auto-generated godocs to be formatted correctly. Please fix this.

Additionally, it looks like there are linting and/or test errors that need fixing. Please address.

[anishrajan25]

@gmlewis I have analysed the existing structs and prepared a document capturing the possibilities of embedding some structs to prevent redefining some fields.

Could you please have a look at this document and add comments wherever necessary to provide your inputs?

I will fix the comments to end with period, linting, and test errors in the next commit along with updating the struct definitions.

[gmlewis]

I'll be back on 9/18 when I can take a look at this. Sorry for the delay and inconvenience.

[anishrajan25]

No worries. You can have a look whenever you are available ✌🏼

[gmlewis]

@anishrajan25 - I'm back, but none of the comments I left above:
#2902 (review)
have been addressed. Please fix these issues before we can continue.

[anishrajan25]

Hi @gmlewis , apologies for the delay in response.

I have created this document, capturing the possibilities of embedding some structs to prevent redefining some fields.
Could you please have a look and add comments wherever necessary to provide your input?

[anishrajan25]

I have updated the existing structs and reused them instead of creating new ones wherever possible. I have fixed the comments as well. @gmlewis Could you please have a look?

[gmlewis]

Please check that test pass locally with go test ./... before pushing.

[anishrajan25]

There are some failing test cases. I will update once the test cases are fixed.

[anishrajan25]

@gmlewis I have fixed the test cases as well. All the tests are passing on my local

[gmlewis]

Please run go generate ./... as described in CONTRIBUTING.md and push the results to this PR.

[codecov]

Codecov Report

Merging #2902 (8d1daf2) into master (5224e34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2902 +/- ##
=======================================
Coverage 98.17% 98.17% =======================================
Files 145 145 Lines 12735 12767 +32 =======================================
+ Hits 12502 12534 +32 
Misses 158 158 Partials 75 75 

Files	Coverage Δ
github/event_types.go	100.00% <ø> (ø)
github/security_advisories.go	100.00% <100.00%> (ø)

[gmlewis]

Thank you, @anishrajan25 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to the repo before merging.

[gmlewis]

Thank you, @valbeat !
Merging.